FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: fix module inspection & instanceof check during inspect by BridgeAR · Pull Request #36178 · nodejs/node · GitHub

/ node Public

util: fix module inspection & instanceof check during inspect - #36178

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:36151/fix-module-inspection
ConversationCommits (2)ChecksFiles changed
Closed

util: fix module inspection & instanceof check during inspect#36178
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:36151/fix-module-inspection

Conversation

BridgeAR commented Nov 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #36151
Fixes: #35730
Refs: #35754

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 19, 2020

ExE-Boss commented Nov 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR should also have the following in the PR description and the message of commit d330cd1:

Supersedes and closes #35754

BridgeAR commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

@ExE-Boss I added a reference to the issue description but I'd just close the PR manually when this PR lands.

benjamingr approved these changes Nov 19, 2020
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actual fix LGTM (pending fixed messages changed in tests probably?)

Also - what semverness should this have?

ExE-Boss commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

@benjamingr

Also - what semverness should this have?

Probably semver‑patch and be backported to v14.x, given that #33449 wasn’t a semver‑major change either.

BridgeAR force-pushed the 36151/fix-module-inspection branch from d330cd1 to 3199002 Compare November 19, 2020 19:15
BridgeAR requested a review from guybedford November 19, 2020 19:17
util: fix module prefixes during inspection
6bf0b56 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: nodejs#36151
util: fix instanceof checks with null prototypes during inspection
cb9eec9 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: nodejs#35730
BridgeAR force-pushed the 36151/fix-module-inspection branch from 3199002 to cb9eec9 Compare November 19, 2020 23:35
BridgeAR added the needs-ci PRs that need a full CI run. label Nov 20, 2020
Trott reviewed Nov 20, 2020
View reviewed changes
Comment thread lib/internal/util/inspect.js

function isInstanceof(object, proto) {
try {
return object instanceof proto;

Trott Nov 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TIL: instanceof can throw

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020

nodejs-github-bot commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34482/

guybedford approved these changes Nov 20, 2020
View reviewed changes

guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks so much for fixing this up. Really nice to surface the null prototype too.

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Dec 7, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2020

nodejs-github-bot commented Dec 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34812/

ExE-Boss commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

The node‑test‑linux‑linked‑debug Jenkins CI build needs restarting.

nodejs-github-bot commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34892/

ExE-Boss commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

node‑test‑linux‑linked‑debug failed again.

BridgeAR commented Dec 12, 2020

Copy link
Copy Markdown
Member Author

@ExE-Boss the failure is an old run and not properly updated :)

BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2020

github-actions Bot commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

Landed in 738cd60...1e66509

github-actions Bot closed this Dec 12, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2020
util: fix module prefixes during inspection
f78da00 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: #36151

PR-URL: #36178
Fixes: #35730
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2020
util: fix instanceof checks with null prototypes during inspection
1e66509 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: #35730

PR-URL: #36178
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ExE-Boss mentioned this pull request Dec 12, 2020
Closed
3 tasks
targos pushed a commit that referenced this pull request Dec 21, 2020
util: fix module prefixes during inspection
13d6597 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: #36151

PR-URL: #36178
Fixes: #35730
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
util: fix instanceof checks with null prototypes during inspection
cc544db 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: #35730

PR-URL: #36178
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Dec 22, 2020
Merged

Pezmc commented Jan 27, 2021 •
edited
Loading

Copy link
Copy Markdown

Is this likely to be backported to 14.x LTS? It doesn't seem to be included in 14.15.3 @ExE-Boss

Edit: trying to follow https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md myself!

Pezmc mentioned this pull request Jan 27, 2021
Closed
Pezmc pushed a commit to Pezmc/node that referenced this pull request Jan 29, 2021
util: fix module prefixes during inspection
19cd35c 
Backport-PR-URL: nodejs#37100

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: nodejs#36151

PR-URL: nodejs#36178
Fixes: nodejs#35730
Refs: nodejs#35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Pezmc pushed a commit to Pezmc/node that referenced this pull request Jan 29, 2021
util: fix instanceof checks with null prototypes during inspection
ce8caa4 
Backport-PR-URL: nodejs#37100

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Fixes: nodejs#35730

PR-URL: nodejs#36178
Fixes: nodejs#36151
Refs: nodejs#35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 5, 2021
util: fix module prefixes during inspection
2f7944b 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #37100
PR-URL: #36178
Fixes: #35730
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 5, 2021
util: fix module prefixes during inspection
8786f1f 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #37100
PR-URL: #36178
Fixes: #35730
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 5, 2021
util: fix instanceof checks with null prototypes during inspection
f206505 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

Backport-PR-URL: #37100
PR-URL: #36178
Fixes: #35730
Fixes: #36151
Refs: #35754
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Feb 5, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
guybedford guybedford approved these changes
Trott Trott approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

9 participants

Back | FazBrowse Home | New Git URL