FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: check callback type of imcoming timeout by aks- · Pull Request #3618 · nodejs/node · GitHub

/ node Public

http: check callback type of imcoming timeout - #3618

Closed
aks- wants to merge 1 commit into
nodejs:masterfrom
aks-:check-callback-type-incoming-timeout
ConversationCommits (1)ChecksFiles changed
Closed

http: check callback type of imcoming timeout#3618
aks- wants to merge 1 commit into
nodejs:masterfrom
aks-:check-callback-type-incoming-timeout

Conversation

aks- commented Oct 31, 2015

Copy link
Copy Markdown
Member

No description provided.

aks- commented Oct 31, 2015

Copy link
Copy Markdown
Member Author

cc @nodejs/http

dougwilson commented Oct 31, 2015

Copy link
Copy Markdown
Member

👎 , protection already exists in EventEmitter.prototype.addListener.

aks- commented Oct 31, 2015

Copy link
Copy Markdown
Member Author

@dougwilson Oho I see. Well then should we have this check here https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L93-L97

dougwilson commented Oct 31, 2015

Copy link
Copy Markdown
Member

Unsure. Was added in PR #3090 , which can help us decide.

mscdex added the http Issues or PRs related to the http subsystem. label Nov 1, 2015

MylesBorins commented Nov 1, 2015

Copy link
Copy Markdown
Contributor

Dupe of #3539

aredridel commented Nov 1, 2015

Copy link
Copy Markdown
Contributor

Kind of a dupe, anyway. That other PR covers other cases.

YurySolovyov reviewed Nov 1, 2015
View reviewed changes
Comment thread lib/_http_incoming.js

YurySolovyov Nov 1, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should be strict check IMO

Fishrock123 Nov 2, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Preferred, yes. Although, typeof only ever returns strings.

aks- mentioned this pull request Nov 2, 2015
Closed
Fishrock123 pushed a commit that referenced this pull request Nov 5, 2015
http: remove unneeded cb check from setTimeout()
8625a38 
- This check is already covered in EventEmitter#addListener()

Refs: #3618
PR-URL: #3631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 commented Nov 5, 2015

Copy link
Copy Markdown
Contributor

Replacement landed in 8625a38

Fishrock123 closed this Nov 5, 2015
rvagg pushed a commit that referenced this pull request Nov 7, 2015
http: remove unneeded cb check from setTimeout()
a7f28a0 
- This check is already covered in EventEmitter#addListener()

Refs: #3618
PR-URL: #3631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL