FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: update node.rc file description by devsnek · Pull Request #36197 · nodejs/node · GitHub

/ node Public

src: update node.rc file description - #36197

Merged
devsnek merged 1 commit into
masterfrom
devsnek-patch-1
Nov 23, 2020
ConversationCommits (1)ChecksFiles changed
Merged

src: update node.rc file description#36197
devsnek merged 1 commit into
masterfrom
devsnek-patch-1

Conversation

devsnek commented Nov 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This is the name that appears in task manager by default

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2020
devsnek added lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform. request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. labels Nov 20, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Nov 20, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34492/

devsnek added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020

github-actions Bot commented Nov 23, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-20T19:56:01Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379142842

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 23, 2020
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 23, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2020

github-actions Bot commented Nov 23, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36197
✔  Done loading data for nodejs/node/pull/36197
----------------------------------- PR info ------------------------------------
Title      src: update node.rc file description (#36197)
Author     devsnek  (@devsnek)
Branch     devsnek:devsnek-patch-1 -> nodejs:master
Labels     lib / src, windows
Commits    1
 - src: update node.rc file description
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36197
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-11-23T14:48:32Z: https://ci.nodejs.org/job/node-test-pull-request/34492/
- Querying data for job/node-test-pull-request/34492/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Fri, 20 Nov 2020 15:42:19 GMT
   ✔  Approvals: 8
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36197#pullrequestreview-535543556
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535567143
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/36197#pullrequestreview-535681875
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/36197#pullrequestreview-535691143
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-535738000
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36197#pullrequestreview-535767332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36197#pullrequestreview-536058722
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/36197#pullrequestreview-536400270
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/379156320

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 23, 2020
src: update node.rc file description
b5d9bd5 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
devsnek merged commit b5d9bd5 into master Nov 23, 2020

devsnek commented Nov 23, 2020

Copy link
Copy Markdown
Member Author

landed in b5d9bd5

devsnek deleted the devsnek-patch-1 branch November 23, 2020 15:27
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
src: update node.rc file description
47397ff 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
src: update node.rc file description
d8cb341 
PR-URL: #36197
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes
aduh95 aduh95 approved these changes
Flarna Flarna approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL