doc: provide additional context by mhdawson · Pull Request #36201 · nodejs/node · GitHub

In the discussion of #35323
it was suggested that we should add some
additional context/clarification.

Signed-off-by: Michael Dawson mdawson@devrus.com

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

@MylesBorins is this along the lines of what you had in mind?

Ironically, the commit message has insufficient context. Maybe this?:

doc: add context for technical values

I think either "will change" or "will evolve" is sufficient.

It would be helpful if the commit log / PR would contain more information about what the additional context is being added to :-)

In the discussion of nodejs#35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com>

@jasnell updated

Signed-off-by: Michael Dawson <mdawson@devrus.com>

@MylesBorins if you can take a look would be good to confirm the concern you had.

LGTM

@mmarchini any chance you can review/approve since you were in the meeting were we discussed as well?

Co-authored-by: Rich Trott <rtrott@gmail.com>

Linters have passed, landing

In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Landed in 6d3775e

In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 20, 2020

Trott reviewed Nov 22, 2020

View reviewed changes