FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark : changed `fstat` to `fstatSync` by Narasimha1997 · Pull Request #36206 · nodejs/node · GitHub

/ node Public

benchmark : changed fstat to fstatSync - #36206

Closed
Narasimha1997 wants to merge 1 commit into
nodejs:masterfrom
Narasimha1997:benchmark-fstat
ConversationCommits (1)ChecksFiles changed
Closed

benchmark : changed fstat to fstatSync#36206
Narasimha1997 wants to merge 1 commit into
nodejs:masterfrom
Narasimha1997:benchmark-fstat

Conversation

Narasimha1997 commented Nov 21, 2020 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Changed fstat to fstatSync as mentioned in the issue #36199

Fixes: #36199

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Nov 21, 2020
aduh95 requested a review from mscdex November 21, 2020 12:56
gireeshpunathil mentioned this pull request Nov 23, 2020
Closed
2 tasks
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2020

This comment has been minimized.

Sign in to view
Narasimha1997 requested a review from aduh95 November 25, 2020 15:08

nodejs-github-bot commented Nov 25, 2020 •
edited by aduh95
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34555/ ✅

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 25, 2020
gireeshpunathil added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2020

github-actions Bot commented Nov 26, 2020

Copy link
Copy Markdown
Contributor

Landed in 2b21a31...49abda7

github-actions Bot closed this Nov 26, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 26, 2020
benchmark : changed fstat to fstatSync
49abda7 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gireeshpunathil commented Nov 26, 2020

Copy link
Copy Markdown
Member

thanks @Narasimha1997 for the contribution! 🎉

Narasimha1997 commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

@gireeshpunathil ,
Thank you so much. Looking forword to contribute and learn more in the coming days.

danielleadams pushed a commit that referenced this pull request Dec 7, 2020
benchmark : changed fstat to fstatSync
2344e3e 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
benchmark : changed fstat to fstatSync
2bbf253 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
gireeshpunathil gireeshpunathil approved these changes
mscdex Awaiting requested review from mscdex
aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark: dead code

7 participants

Back | FazBrowse Home | New Git URL