dns: Update to c-ares 1.17.1 by lxdicted · Pull Request #36207 · nodejs/node · GitHub

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Review requested:

@nodejs/net

CI: https://ci.nodejs.org/job/node-test-pull-request/34504/

CI: https://ci.nodejs.org/job/node-test-pull-request/34518/

CI: https://ci.nodejs.org/job/node-test-pull-request/34534/

When this PR is landed, should this be landed as a separate commit that can be floated as a patch for subsequent updates?

This piece of code is used in other places of c-ares, too. I'm going to provide a pull request for it in c-ares. Don't know how this should be handled in nodejs.

@richardlau I can't see, how these failing tests relate to this pull request:

12:24:29 not ok 2497 parallel/test-webcrypto-derivebits-hkdf
12:24:29   ---
12:24:29   duration_ms: 122.197
12:24:29   severity: fail
12:24:29   exitcode: -15
12:24:29   stack: |-
12:24:29     timeout
12:24:29   ...
12:24:29 not ok 2498 parallel/test-webcrypto-derivebits-node-dh
12:24:29   ---
12:24:29   duration_ms: 121.988
12:24:29   severity: fail
12:24:29   exitcode: -15
12:24:29   stack: |-
12:24:29     timeout
12:24:29   ...
12:25:44 not ok 2499 parallel/test-webcrypto-derivebits-pbkdf2
12:25:50   ---
12:26:05   duration_ms: 180.679
12:26:05   severity: fail
12:26:05   exitcode: -15
12:26:05   stack: |-
12:26:05     timeout
12:26:05   ...

Help would be very welcome to track this down, if this is related to this pull request.

CI: https://ci.nodejs.org/job/node-test-pull-request/34587/

@nodejs/dns

CI: https://ci.nodejs.org/job/node-test-pull-request/34636/

CI Internet tests: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/17846/

Can you explain the process you did to update this? (Maybe there's a doc somewhere I should be following along with?) I would have expected this to update deps/cares/include/ares_version.h but that file is unchanged.

@Trott I've did the following:

downloaded the old integrated version (1.16.1) and diffed its content against node's deps/cares
downloaded the current version (1.17.1), and
copied all files of it into deps/cares/{src,include}.
verified, that the changes only in node (from 1.), are not removed with my commit.

@nodejs/tsc Any ideas for domain experts who can review this? I can review it, but I wouldn't feel great about it if there wasn't someone more knowledgable giving it another pair of eyes.

Note for whoever lands this: Subsystem should probably be deps.

CI: https://ci.nodejs.org/job/node-test-pull-request/34876/

Internet CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/18052/

lgtm

PR-URL: nodejs#36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Landed in 3bd9b81

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs/node#36207

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

c-ares refactored their source tree in 1.17.0 which we did not apply in our update to 1.17.1. This commit syncs our source with their new structure for easier maintenance going forward. cares.gyp is updated accordingly. Refs: c-ares/c-ares#349 Refs: nodejs#36207

PR-URL: #39653 Refs: c-ares/c-ares#349 Refs: #36207 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

c-ares refactored their source tree in 1.17.0 which we did not apply in our update to 1.17.1. This commit syncs our source with their new structure for easier maintenance going forward. cares.gyp is updated accordingly. Refs: c-ares/c-ares#349 Refs: #36207 PR-URL: #39653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Nov 21, 2020

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2020

lxdicted force-pushed the feature/c-ares-1.17.1 branch from b6ef1e1 to f8de31a Compare November 21, 2020 17:32

lxdicted mentioned this pull request Nov 24, 2020

Feature/dns caa #35466

Closed

4 tasks

Trott reviewed Nov 25, 2020

View reviewed changes

lxdicted added a commit to lxdicted/c-ares that referenced this pull request Nov 25, 2020

Compile fix taken from nodejs/node#36207

e250667

lxdicted mentioned this pull request Nov 25, 2020

Compile fix taken from https://github.com/nodejs/node/pull/36207 c-ares/c-ares#385

Closed

lxdicted force-pushed the feature/c-ares-1.17.1 branch from 916e38b to a4902f0 Compare December 6, 2020 13:44

Trott added the dns Issues and PRs related to the dns subsystem. label Dec 9, 2020

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2020

mcollina approved these changes Dec 12, 2020

View reviewed changes

codebytere approved these changes Dec 12, 2020

View reviewed changes

Trott approved these changes Dec 14, 2020

View reviewed changes

deps: update to c-ares 1.17.1

3bd9b81

PR-URL: nodejs#36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott force-pushed the feature/c-ares-1.17.1 branch from a4902f0 to 3bd9b81 Compare December 16, 2020 13:49

Trott merged commit 3bd9b81 into nodejs:master Dec 16, 2020

targos pushed a commit that referenced this pull request Dec 21, 2020

deps: update to c-ares 1.17.1

cb4652e

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos mentioned this pull request Dec 22, 2020

v15.5.0 release proposal #36597

Merged

targos pushed a commit that referenced this pull request May 1, 2021

deps: update to c-ares 1.17.1

5747dff

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

codebytere added a commit to electron/electron that referenced this pull request May 14, 2021

dns: Update to c-ares 1.17.1

de2de28

nodejs/node#36207

codebytere added a commit to electron/electron that referenced this pull request May 18, 2021

dns: Update to c-ares 1.17.1

66264bc

nodejs/node#36207

richardlau pushed a commit that referenced this pull request Jul 26, 2021

deps: update to c-ares 1.17.1

e11a862

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

richardlau mentioned this pull request Jul 26, 2021

v12.22.4 proposal #39500

Merged

richardlau pushed a commit that referenced this pull request Jul 26, 2021

deps: update to c-ares 1.17.1

f2c4739

PR-URL: #36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs mentioned this pull request Aug 3, 2021

deps: reflect c-ares source tree #39653

Closed

dns: Update to c-ares 1.17.1 by lxdicted · Pull Request #36207 · nodejs/node · GitHub

Uh oh!

Uh oh!

dns: Update to c-ares 1.17.1 - #36207

dns: Update to c-ares 1.17.1#36207Trott merged 1 commit intonodejs:masternodejs/node:masterfrom lxdicted:feature/c-ares-1.17.1lxdicted/node:feature/c-ares-1.17.1Copy head branch name to clipboard

Conversation

lxdicted commented Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 21, 2020

Uh oh!

nodejs-github-bot commented Nov 21, 2020

Uh oh!

nodejs-github-bot commented Nov 23, 2020

Uh oh!

nodejs-github-bot commented Nov 24, 2020

Uh oh!

Trott Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

lxdicted Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

lxdicted commented Nov 25, 2020

Uh oh!

nodejs-github-bot commented Nov 27, 2020

Uh oh!

Trott commented Nov 30, 2020

Uh oh!

nodejs-github-bot commented Nov 30, 2020

Uh oh!

Trott commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 2, 2020

Uh oh!

lxdicted commented Dec 6, 2020

Uh oh!

Trott commented Dec 9, 2020

Uh oh!

Trott commented Dec 9, 2020

Uh oh!

nodejs-github-bot commented Dec 9, 2020

Uh oh!

Trott commented Dec 12, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dns: Update to c-ares 1.17.1#36207
Trott merged 1 commit into
nodejs:masterfrom
lxdicted:feature/c-ares-1.17.1

lxdicted commented Nov 21, 2020 •
edited
Loading

Trott commented Dec 2, 2020 •
edited
Loading