test: missed warning for non-experimental AbortController - #36240
Merged
Trott merged 1 commit intoNov 24, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Nov 23, 2020
Copy link
Copy Markdown
Contributor
|
👍 to fast-track |
Sorry, something went wrong.
mhdawson
approved these changes
Nov 23, 2020
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Just waiting on CI to finish to land. |
Sorry, something went wrong.
codebytere
approved these changes
Nov 24, 2020
Copy link
Copy Markdown
Member
node-core-utils warns about that. If it didn't warn about that, maybe update to the newest version? |
Sorry, something went wrong.
Trott
approved these changes
Nov 24, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#36240 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
missed-warning
branch
from
551047e to
4388c14
Compare
November 24, 2020 04:51
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36240 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was missed when landing PR (change landed after the CI had run). Should fast-track this.
Signed-off-by: James M Snell jasnell@gmail.com
Checklist