readline: refactor to use more primordials - #36296
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Nov 29, 2020
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 4, 2020
PR-URL: #36296 Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36296 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36296 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36296 Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
|
Hey, this is breaking in the v16.x release branch by the avoid-prototype-pollution lint rule; I was considering doing something like you did on this line: https://github.com/nodejs/node/pull/43476/files#diff-5a4538cd718c611584a97c379b5445c006a886ea9b90734080f3434c4abc1ff0R34; simply commenting the linter. But this is not my code; I decided to request a backport fo v16.x |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Nevermind, this is a quite all commit; this is part of v16.x branch already. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist