FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky test-http2-respond-file-error-pipe-offset by Trott · Pull Request #36305 · nodejs/node · GitHub

/ node Public

test: fix flaky test-http2-respond-file-error-pipe-offset - #36305

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:sprig
Dec 7, 2020
ConversationCommits (0)ChecksFiles changed
Merged

test: fix flaky test-http2-respond-file-error-pipe-offset#36305
Trott merged 0 commit into
nodejs:masterfrom
Trott:sprig

Conversation

Trott commented Nov 28, 2020

Copy link
Copy Markdown
Member

Fixes: #35881

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 28, 2020
Trott mentioned this pull request Nov 28, 2020
Closed
Trott changed the title test: fix falky test-http2-respond-file-error-pipe-offset test: fix flaky test-http2-respond-file-error-pipe-offset Nov 28, 2020
Trott requested a review from addaleax November 28, 2020 16:38
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

szmarczak commented Dec 2, 2020

Copy link
Copy Markdown
Member

Can't we use a UNIX socket instead?

Trott commented Dec 2, 2020

Copy link
Copy Markdown
Member Author

Can't we use a UNIX socket instead?

I'm under the impression that the test is specifically for an issue involving pipes, but I could be wrong. /ping @addaleax

addaleax approved these changes Dec 2, 2020
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this is fine, as would be using a socket. The important thing is that the target file is not seekable.

nodejs-github-bot commented Dec 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34729/

nodejs-github-bot commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34742/

nodejs-github-bot commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34748/

nodejs-github-bot commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34767/

Trott closed this Dec 7, 2020
Trott merged commit f178c5a into nodejs:master Dec 7, 2020

Trott commented Dec 7, 2020

Copy link
Copy Markdown
Member Author

Landed in f178c5a

Trott deleted the sprig branch December 7, 2020 15:31
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
test: fix flaky test-http2-respond-file-error-pipe-offset
a7e794d 
Fixes: #35881

PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams mentioned this pull request Dec 7, 2020
Merged
targos pushed a commit that referenced this pull request Apr 25, 2021
test: fix flaky test-http2-respond-file-error-pipe-offset
cd1da67 
Fixes: #35881

PR-URL: #36305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-respond-file-error-pipe-offset

4 participants

Back | FazBrowse Home | New Git URL