FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

child_process: add AbortSignal support by benjamingr · Pull Request #36308 · nodejs/node · GitHub

/ node Public

child_process: add AbortSignal support - #36308

Closed
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:child-process-abort-signal
ConversationCommits (1)ChecksFiles changed
Closed

child_process: add AbortSignal support#36308
benjamingr wants to merge 1 commit into
nodejs:masterfrom
benjamingr:child-process-abort-signal

Conversation

benjamingr commented Nov 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Support AbortSignal in child_process.execFile.

Bikeshedding:

  • I know everywhere else it's called signal and that it's the web platform guidance - but I think we might want to deviate here and call the parameter abortSignal to prevent confusion with OS signals and killSignal. WDYT?

I will follow up with support in the other child_process APIs like fork and spawn.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Nov 28, 2020
benjamingr force-pushed the child-process-abort-signal branch from 18912bb to a3cdc6c Compare November 28, 2020 19:46
benjamingr marked this pull request as ready for review November 29, 2020 14:38
benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2020

nodejs-github-bot commented Nov 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34620/

Trott commented Dec 1, 2020

Copy link
Copy Markdown
Member

@nodejs/child_process

Trott reviewed Dec 1, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated

Trott Dec 1, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's called signal above, right? (I guess this is what your bikeshedding note is about.)

benjamingr Dec 1, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No I think this is just a mistake on my part unrelated to the bikeshedding?

Trott reviewed Dec 1, 2020
View reviewed changes
Comment thread doc/api/child_process.md Outdated
Comment on lines 341 to 340

Trott Dec 1, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
For example:

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 1, 2020

addaleax commented Dec 1, 2020

Copy link
Copy Markdown
Member

I, for one, would love more consistency between the different child_process.* methods, so if we could add this to all of the async ones at once or not at all, I think that might be nice (except maybe spawn because that’s “more async” in a way, but then again, why not also spawn? … 🙂 )

benjamingr commented Dec 1, 2020

Copy link
Copy Markdown
Member Author

@addaleax I intend to add them to all of the APIs - I just find large'ish PRs are harder to land in Node and get meaningful reviews so I made smaller ones. The idea is to add this to fork and spawn later.

If you feel strongly that it should happen in the same PR I am happy to push the commit that adds it to fork and span here if you will review it (Perhaps I already have a branch with a commit on top of this one that adds it 😅 ).

Otherwise I would rather land this and then land the spawn/fork changes in a follow up PR.

benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 1, 2020
benjamingr force-pushed the child-process-abort-signal branch from a3cdc6c to 1da4e0b Compare December 5, 2020 20:07
benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020

nodejs-github-bot commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34776/

benjamingr force-pushed the child-process-abort-signal branch from 1da4e0b to 72fac8b Compare December 5, 2020 21:05
benjamingr added a commit that referenced this pull request Dec 6, 2020
child_process: add AbortSignal support
20de5f7 
PR-URL: #36308
Reviewed-By: Rich Trott <rtrott@gmail.com>

benjamingr commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

Landed in 20de5f7 will follow up shortly with form and spawn

benjamingr closed this Dec 6, 2020
benjamingr deleted the child-process-abort-signal branch December 6, 2020 10:24

benjamingr commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

I think somehow ncu pushed something that shouldn't have been here - investigating

benjamingr commented Dec 6, 2020

Copy link
Copy Markdown
Member Author

It looks like indeed this landed after last CI since I squashed, somehow this change that wasn't in the original (and commits) and didn't go through CI got in.

This is probably a PBKAC on my part and I landed the squashed commit with NCU

benjamingr mentioned this pull request Dec 6, 2020
Closed
4 tasks
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
child_process: add AbortSignal support
224a647 
PR-URL: #36308
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Dec 7, 2020
Merged
danielleadams added a commit that referenced this pull request Dec 7, 2020
2020-12-08, Version 15.4.0 (Current)
fde09a4 
PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
danielleadams added a commit that referenced this pull request Dec 9, 2020
2020-12-09, Version 15.4.0 (Current)
5e5927e 
PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
danielleadams added a commit that referenced this pull request Dec 9, 2020
2020-12-09, Version 15.4.0 (Current)
348b7a9 
PR-URL: #36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (#36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (#36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (#36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (#35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (#35924)
* module:
  * add isPreloading indicator (James M Snell) (#36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (#36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (#35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (#36271)
targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
child_process: add AbortSignal support
8277ec1 
PR-URL: nodejs#36308
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
child_process: add AbortSignal support
a5c0f39 
PR-URL: #36308
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax Awaiting requested review from addaleax
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL