tools: update highlight.js to 10.1.2 - #36309
Merged
Trott merged 1 commit intoNov 30, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Can we please fast-track |
Sorry, something went wrong.
aduh95
approved these changes
Nov 28, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Nov 29, 2020
Copy link
Copy Markdown
Member
|
I ran make doc-only with and without this change (after running npm ci in the relevant directory) and there was no change to the resulting docs, so that's good. |
Sorry, something went wrong.
benjamingr
approved these changes
Nov 29, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good the CI was stuck and ran for 14 hours so I kicked off a new one |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Refs: GHSA-vfrc-7r7c-w9mx PR-URL: nodejs#36309 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott
force-pushed
the
update-highlight
branch
from
2058676 to
f34866a
Compare
November 30, 2020 04:27
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
Refs: GHSA-vfrc-7r7c-w9mx PR-URL: #36309 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: GHSA-vfrc-7r7c-w9mx PR-URL: #36309 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: GHSA-vfrc-7r7c-w9mx