dns: refactor to use more primordials - #36314
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
Author
|
Benchmark CI didn't show any perf regression or improvement. Detailsconfidence improvement accuracy (*) (**) (***) dns/lookup.js n=5000000 all='false' name='::1' 1.68 % ±2.48% ±3.30% ±4.29% dns/lookup.js n=5000000 all='false' name='127.0.0.1' -2.53 % ±5.59% ±7.46% ±9.76% dns/lookup.js n=5000000 all='true' name='::1' 0.05 % ±2.09% ±2.79% ±3.63% dns/lookup.js n=5000000 all='true' name='127.0.0.1' -2.49 % ±4.02% ±5.36% ±7.00% dns/lookup-promises.js n=5000000 all='false' name='::1' 12.40 % ±16.94% ±22.79% ±30.16% dns/lookup-promises.js n=5000000 all='false' name='127.0.0.1' 0.95 % ±3.04% ±4.04% ±5.26% dns/lookup-promises.js n=5000000 all='true' name='::1' 5.62 % ±9.65% ±12.97% ±17.15% dns/lookup-promises.js n=5000000 all='true' name='127.0.0.1' 0.88 % ±4.24% ±5.64% ±7.35% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case there are 8 comparisons, you can thus expect the following amount of false-positive results: 0.40 false positives, when considering a 5% risk acceptance (*, **, ***), 0.08 false positives, when considering a 1% risk acceptance (**, ***), 0.01 false positives, when considering a 0.1% risk acceptance (***) |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Dec 2, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Dec 7, 2020
Copy link
Copy Markdown
Member
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2021
PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36314 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist