FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

worker: refactor MessagePort entanglement management by addaleax · Pull Request #36345 · nodejs/node · GitHub

/ node Public

worker: refactor MessagePort entanglement management - #36345

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:messageport-entanglement
ConversationCommits (1)ChecksFiles changed
Closed

worker: refactor MessagePort entanglement management#36345
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:messageport-entanglement

Conversation

addaleax commented Dec 1, 2020

Copy link
Copy Markdown
Member

This addresses the TODO left on my request in 9e446b3. :)

Refs: #36271

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

worker: refactor MessagePort entanglement management
6334542 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: nodejs#36271
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2020
addaleax requested a review from jasnell December 1, 2020 20:20
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 1, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2020

nodejs-github-bot commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34656/

nodejs-github-bot commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34666/

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2020

nodejs-github-bot commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34764/

nodejs-github-bot commented Dec 5, 2020 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34785/ ✅

addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2020

github-actions Bot commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Landed in e28f23f...88dfecc

github-actions Bot closed this Dec 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 13, 2020
worker: refactor MessagePort entanglement management
88dfecc 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: #36271

PR-URL: #36345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax deleted the messageport-entanglement branch December 13, 2020 14:29
targos pushed a commit that referenced this pull request Dec 21, 2020
worker: refactor MessagePort entanglement management
56fe9ba 
This addresses the `TODO` left on my request in 9e446b3. :)

Refs: #36271

PR-URL: #36345
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Dec 22, 2020
Merged
richardlau mentioned this pull request Jul 16, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL