FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v12.x backport] v8: implement v8.takeCoverage() and v8.stopCoverage() by rickyes · Pull Request #36352 · nodejs/node · GitHub

/ node Public

[v12.x backport] v8: implement v8.takeCoverage() and v8.stopCoverage() - #36352

Merged
richardlau merged 2 commits into
nodejs:v12.x-stagingfrom
rickyes:backport-33807-to-v12.x
Mar 17, 2021
ConversationCommits (2)ChecksFiles changed
Merged

[v12.x backport] v8: implement v8.takeCoverage() and v8.stopCoverage()#36352
richardlau merged 2 commits into
nodejs:v12.x-stagingfrom
rickyes:backport-33807-to-v12.x

Conversation

rickyes commented Dec 2, 2020

Copy link
Copy Markdown
Contributor
Checklist

PR-URL: #33807

Reviewed-By: @gengjiawen
Reviewed-By: @bcoe
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Dec 2, 2020

rickyes commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

/cc @joyeecheung

rickyes added semver-minor PRs that contain new features and should be released in the next minor version. coverage Issues and PRs related to native coverage support. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 2, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020

nodejs-github-bot commented Dec 2, 2020 •
edited by rickyes
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34685/ ✅

bcoe commented Dec 18, 2020

Copy link
Copy Markdown
Contributor

@Trott I'm not sure what the back-porting process entails, perhaps you could give a hand here?

Trott commented Dec 24, 2020

Copy link
Copy Markdown
Member

@Trott I'm not sure what the back-porting process entails, perhaps you could give a hand here?

Because 12.x is LTS, I believe only people in @nodejs/releasers should land these kinds of PRs. 12.x is Maintenance and so I think semver-minor PRs like this one typically don't land there, but I could be wrong. So they may need you or someone else to make the case for landing it.

MylesBorins commented Dec 26, 2020

Copy link
Copy Markdown
Contributor

12.x is now in maintenance and we are unlikely to do another semver minor release

rickyes commented Jan 14, 2021

Copy link
Copy Markdown
Contributor Author

Maybe we can make another semver minor release？ @nodejs/releasers may have to ask for your help.

atian25 commented Jan 14, 2021

Copy link
Copy Markdown
Contributor

12.x is now in maintenance and we are unlikely to do another semver minor release

This PR was proposed when it's still at the LTS phase, but has been waiting for the Review to land and it is no longer LTS.

nodejs-github-bot commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36729/

nodejs-github-bot commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36744/

v8: implement v8.takeCoverage()
8ddea3f 
Add an v8.takeCoverage() API that allows the user to write the
coverage started by NODE_V8_COVERAGE to disk on demand.
The coverage can be written multiple times during the lifetime
of the process, each time the execution counter will be reset.
When the process is about to exit, one last coverage will
still be written to disk.

Also refactors the internal profiler connection code
so that we use the inspector response id to identify
the profile response instead of using an ad-hoc flag in C++.

PR-URL: nodejs#33807
Backport-PR-URL: nodejs#36352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
v8: implement v8.stopCoverage()
86f34ee 
Add a v8.stopCoverage() API to stop the coverage collection
started by NODE_V8_COVERAGE - this would be useful in
conjunction with v8.takeCoverage() if the user don't want
to emit the coverage at the process exit but still want
to collect it on demand at some point.

PR-URL: nodejs#33807
Backport-PR-URL: nodejs#36352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
richardlau force-pushed the backport-33807-to-v12.x branch from 2d36fe4 to 86f34ee Compare March 17, 2021 20:54

richardlau commented Mar 17, 2021

Copy link
Copy Markdown
Member

Landed in d7a4ccd...86f34ee

richardlau merged commit 86f34ee into nodejs:v12.x-staging Mar 17, 2021
rickyes deleted the backport-33807-to-v12.x branch March 23, 2021 12:35
This was referenced Aug 16, 2022
Open
Open
Dmarch28 mentioned this pull request Aug 16, 2022
Open
wedataintelligence mentioned this pull request Aug 16, 2022
Open
kissofire mentioned this pull request Aug 16, 2022
Open
molllyn1 mentioned this pull request Aug 17, 2022
Open
snyk-bot mentioned this pull request Aug 17, 2022
Open
baby636 mentioned this pull request Aug 17, 2022
Open
ron-a20 mentioned this pull request Aug 17, 2022
Open
snyk-bot mentioned this pull request Sep 25, 2022
Open
wedataintelligence mentioned this pull request Sep 26, 2022
Open
137717unity mentioned this pull request Sep 26, 2022
Open
snyk-bot mentioned this pull request Sep 27, 2022
Open
wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
snyk-bot mentioned this pull request Oct 6, 2022
Open
137717unity mentioned this pull request Oct 7, 2022
Open
wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
137717unity mentioned this pull request Oct 9, 2022
Open
snyk-bot mentioned this pull request Oct 9, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes
+1 more reviewer
bcoe bcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. coverage Issues and PRs related to native coverage support. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL