Update https.md - #36370
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pronouns are OK in our docs, so if you want to use you instead of one, that would be fine:
| class. The `ClientRequest` instance is a writable stream. If one needs to | |
| class. The `ClientRequest` instance is a writable stream. If you need to |
Sorry, something went wrong.
There was a problem hiding this comment.
Do we need any of this information in the text if it's been added to line 278 above? Maybe the paragraph can go but the other addition can stay?
| `https.request()` returns an instance of the [`http.ClientRequest`][] | |
| class. The `ClientRequest` instance is a writable stream. If one needs to | |
| upload a file with a POST request, then write to the `ClientRequest` object. |
Sorry, something went wrong.
There was a problem hiding this comment.
This paragraph was copied from http.request, includes the use of 'one'. All I did was add a single letter 's' to 'http':
https://github.com/nodejs/node/blob/master/doc/api/http.md#httprequesturl-options-callback
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without my suggestions.
Sorry, something went wrong.
Add missing topic about what https.request() returns. PR-URL: nodejs#36370 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
|
Landed in 9df3b76 🎉 Thanks for the contribution. |
Sorry, something went wrong.
Add missing topic about what https.request() returns. PR-URL: #36370 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Add missing topic about what https.request() returns. PR-URL: #36370 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Add missing topic about what https.request() returns.