FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add version metadata to timers/promises by cjihrig · Pull Request #36378 · nodejs/node · GitHub

/ node Public

doc: add version metadata to timers/promises - #36378

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: add version metadata to timers/promises#36378
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:doc

Conversation

cjihrig commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Refs: #33950

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 4, 2020
cjihrig mentioned this pull request Dec 4, 2020
Closed
4 tasks
benjamingr approved these changes Dec 4, 2020
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch

cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2020

github-actions Bot commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Landed in 20de5f7...2f49720

nodejs-github-bot pushed a commit that referenced this pull request Dec 6, 2020
doc: add version metadata to timers/promises
2f49720 
Refs: #33950

PR-URL: #36378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
github-actions Bot closed this Dec 6, 2020
cjihrig deleted the doc branch December 6, 2020 15:55
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
doc: add version metadata to timers/promises
2649c38 
Refs: #33950

PR-URL: #36378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams mentioned this pull request Dec 7, 2020
Merged
baby636 mentioned this pull request Nov 28, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
watilde watilde approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
styfle styfle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL