domains: emit uncaughtException when appropriate - #3638
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Require common please
Sorry, something went wrong.
|
@misterdjules ... just a quick note: we'll want to land this in v0.12-staging first. Per the LTS WG discussion on monday, we're going to try use the -staging branches to help organize the LTS releases from v4.x, v0.12 and v0.10 going forward. |
Sorry, something went wrong.
Sorry, something went wrong.
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when no error handler is set on the domain within which an error is thrown and an `'uncaughtException'` event listener is set on the process. Fixes nodejs#3607.
Make the process abort if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. If the domain within which the error is thrown has no error handler, but a domain further down the domains stack has one, the process will not abort. Fixes nodejs#3653
|
@jbergstroem Thank you for running the tests on this. I think the correct link to the CI results is https://ci.nodejs.org/job/node-test-commit/1040/. Anyway, I needed to run tests again because since then I updated this PR with a new commit. CI running here: https://ci.nodejs.org/job/node-test-pull-request/677/. |
Sorry, something went wrong.
Fix node exiting due to an exception being thrown rather than emitting
an 'uncaughtException' event on the process object when no error
handler is set on the domain within which an error is thrown and an
'uncaughtException' event listener is set on the process.
Fixes #3607.
/cc @nodejs/lts @nodejs/tsc @nodejs/collaborators