FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 7.15.0 by cjihrig · Pull Request #36411 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 7.15.0 - #36411

Closed
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:eslint
ConversationCommits (2)ChecksFiles changed
Closed

tools: update ESLint to 7.15.0#36411
cjihrig wants to merge 2 commits into
nodejs:masterfrom
cjihrig:eslint

Conversation

cjihrig commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Update ESLint to 7.15.0 and enable the new no-unsafe-optional-chaining rule.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 6, 2020
aduh95 approved these changes Dec 8, 2020
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions Bot commented Dec 8, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36411
✔  Done loading data for nodejs/node/pull/36411
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.15.0 (#36411)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    2
 - tools: update ESLint to 7.15.0
 - tools: enable no-unsafe-optional-chaining lint rule
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
   ℹ  This PR was created on Sun, 06 Dec 2020 15:19:00 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/408627427

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 8, 2020
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 8, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2020

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2020

github-actions Bot commented Dec 8, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36411
✔  Done loading data for nodejs/node/pull/36411
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.15.0 (#36411)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     author ready, tools
Commits    2
 - tools: update ESLint to 7.15.0
 - tools: enable no-unsafe-optional-chaining lint rule
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-12-08T17:36:33Z: https://ci.nodejs.org/job/node-test-pull-request/34850/
- Querying data for job/node-test-pull-request/34850/
✔  Build data downloaded
- Querying failures of job/node-test-commit/42841/
✔  Data downloaded
   ✖  3 failure(s) on the last Jenkins CI run
   ℹ  This PR was created on Sun, 06 Dec 2020 15:19:00 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988
   ✔  - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/408983371

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 8, 2020

nodejs-github-bot commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34855/

nodejs-github-bot commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34878/

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 9, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2020

github-actions Bot commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Landed in 27a63ee...a26ae70

github-actions Bot closed this Dec 9, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 9, 2020
tools: update ESLint to 7.15.0
514da38 
Update ESLint to 7.15.0

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 9, 2020
tools: enable no-unsafe-optional-chaining lint rule
a26ae70 
This rule is new in ESLint 7.15.0.

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
cjihrig deleted the eslint branch December 9, 2020 16:43
targos pushed a commit that referenced this pull request Dec 21, 2020
tools: update ESLint to 7.15.0
26f8ccf 
Update ESLint to 7.15.0

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
tools: enable no-unsafe-optional-chaining lint rule
7542a3b 
This rule is new in ESLint 7.15.0.

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 16, 2021
tools: update ESLint to 7.15.0
e5de7b6 
Update ESLint to 7.15.0

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
tools: enable no-unsafe-optional-chaining lint rule
a67e392 
This rule is new in ESLint 7.15.0.

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
tools: update ESLint to 7.15.0
7d41192 
Update ESLint to 7.15.0

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
tools: enable no-unsafe-optional-chaining lint rule
98806da 
This rule is new in ESLint 7.15.0.

PR-URL: #36411
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
watilde watilde approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL