test: increased externalized string length - #36451
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry, something went wrong.
cjihrig
approved these changes
Dec 9, 2020
fhinkel
approved these changes
Dec 10, 2020
Copy link
Copy Markdown
Member
Author
|
@gireeshpunathil unfortunately V8's bug tracker was pretty unclear about this - I couldn't find a specific minimum length specified. I don't believe this affects other aspects of Node.js beyond direct calls to externalizeString, no. The larger tracking bug is here: https://bugs.chromium.org/p/v8/issues/detail?id=7790 which may provide more insight? |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Dec 12, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
codebytere
added a commit
that referenced
this pull request
Dec 13, 2020
PR-URL: #36451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2565511.
V8 has removed the ability to externalize internal external uncached strings via MakeExternal, as it is not thread-safe. This means that the examples that are in the test at present will begin to fail once Node.js rolls in the relevant CL, because their small size made them internal external uncached strings. This preemptively fixes the issue by making the strings bigger so they become internal & external & cached.
Electron hit and fixed this in electron/electron@0bf50b0
Checklist