FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add v15.4.0 link to CHANGELOG.md by danielleadams · Pull Request #36456 · nodejs/node · GitHub

/ node Public

doc: add v15.4.0 link to CHANGELOG.md - #36456

Closed
danielleadams wants to merge 1 commit into
nodejs:masterfrom
danielleadams:add-v15.4.0-to-changelog
ConversationCommits (1)ChecksFiles changed
Closed

doc: add v15.4.0 link to CHANGELOG.md#36456
danielleadams wants to merge 1 commit into
nodejs:masterfrom
danielleadams:add-v15.4.0-to-changelog

Conversation

danielleadams commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
Description

Adding a link to the CHANGELOG.md for the latest 15.x release.

Checklist

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 9, 2020

danielleadams commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

Should this be merged into master or wait to cherry-pick this into the next 15.x release?

Trott commented Dec 13, 2020

Copy link
Copy Markdown
Member

Should this be merged into master or wait to cherry-pick this into the next 15.x release?

I imagine this question is aimed at other @nodejs/releasers members? I'd assumed land on master but defer to the opinion of @nodejs/releasers members as I'm not sure if or how anything like that would affect the release process.

MylesBorins commented Dec 14, 2020

Copy link
Copy Markdown
Contributor

I think merge into master and cherry-pick to 15 makes the most sense. We want this fixed in both.

MylesBorins approved these changes Dec 14, 2020
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins commented Dec 14, 2020

Copy link
Copy Markdown
Contributor

Landed in 04e5418

MylesBorins pushed a commit that referenced this pull request Dec 14, 2020
doc: add v15.4.0 link to CHANGELOG.md
04e5418 
PR-URL: #36456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
doc: add v15.4.0 link to CHANGELOG.md
25a2454 
PR-URL: #36456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
targos mentioned this pull request Dec 22, 2020
Merged
danielleadams deleted the add-v15.4.0-to-changelog branch March 4, 2022 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
codebytere codebytere approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
+2 more reviewers
fhinkel fhinkel approved these changes
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL