FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ini in tools/node-lint-md-cli-rollup by MylesBorins · Pull Request #36474 · nodejs/node · GitHub

/ node Public

tools: update ini in tools/node-lint-md-cli-rollup - #36474

Closed
MylesBorins wants to merge 2 commits into
nodejs:masterfrom
MylesBorins:update-ini
Closed

tools: update ini in tools/node-lint-md-cli-rollup#36474
MylesBorins wants to merge 2 commits into
nodejs:masterfrom
MylesBorins:update-ini

Conversation

Copy link
Copy Markdown
Contributor

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

can we please fast-track?

MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2020

Copy link
Copy Markdown
Collaborator

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You need to rebuild lint-md.js and include the resulting file in the PR for this to have any effect.

Trott commented Dec 11, 2020

Copy link
Copy Markdown
Member

You need to rebuild lint-md.js and include the resulting file in the PR for this to have any effect.

I did that and added it as a second commit to keep this moving. Feel free to squash it to one commit if you want.

Copy link
Copy Markdown
Collaborator

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 11, 2020
MylesBorins added a commit that referenced this pull request Dec 11, 2020
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Copy link
Copy Markdown
Contributor Author

landed in 7faeddf

targos pushed a commit that referenced this pull request Dec 21, 2020
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
Refs: #36473
Refs: GHSA-qqgx-2p2h-9c37

PR-URL: #36474
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL