FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: refactor to use more primordials in internal/encoding.js by RaisinTen · Pull Request #36480 · nodejs/node · GitHub

/ node Public

lib: refactor to use more primordials in internal/encoding.js - #36480

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/refactor-to-use-more-primordials-in-internal/encoding.js
ConversationCommits (1)ChecksFiles changed
Closed

lib: refactor to use more primordials in internal/encoding.js#36480
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/refactor-to-use-more-primordials-in-internal/encoding.js

Conversation

RaisinTen commented Dec 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Dec 11, 2020
RaisinTen force-pushed the lib/refactor-to-use-more-primordials-in-internal/encoding.js branch from 33c364d to 36f8579 Compare December 11, 2020 17:23
RaisinTen marked this pull request as ready for review December 11, 2020 17:24

Trott commented Dec 13, 2020

Copy link
Copy Markdown
Member

Should any benchmarks be run on this before landing? This file gets used in util.js, internal/crypto/webcrypto.js, and internal/bootstrap/node.js.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020

nodejs-github-bot commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34926/

PoojaDurgad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 18, 2020

aduh95 commented Dec 22, 2020

Copy link
Copy Markdown
Contributor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/790/

aduh95 commented Dec 26, 2020

Copy link
Copy Markdown
Contributor

Another benchmark CI to be sure there's no regression: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/806/ (queued, will 404 until it starts)

aduh95 approved these changes Dec 26, 2020
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No regression found in the benchmark

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 26, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 26, 2020

github-actions Bot commented Dec 26, 2020

Copy link
Copy Markdown
Contributor

Landed in 9df3b76...c4cbdfa

github-actions Bot closed this Dec 26, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 26, 2020
lib: refactor to use more primordials in internal/encoding.js
c4cbdfa 
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RaisinTen deleted the lib/refactor-to-use-more-primordials-in-internal/encoding.js branch December 27, 2020 06:39
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
lib: refactor to use more primordials in internal/encoding.js
6e338da 
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
lib: refactor to use more primordials in internal/encoding.js
3638a31 
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
lib: refactor to use more primordials in internal/encoding.js
396c553 
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
lib: refactor to use more primordials in internal/encoding.js
01a71dd 
PR-URL: #36480
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 approved these changes
+2 more reviewers
targos targos approved these changes
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL