test: increase coverage for worker - #36491
Closed
Lxxyx wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gireeshpunathil
approved these changes
Dec 12, 2020
targos
approved these changes
Dec 13, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179
Lxxyx
force-pushed
the
test-worker-coverage
branch
from
00acfad to
43f1008
Compare
December 14, 2020 17:01
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Dec 15, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 17, 2020
juanarbol
approved these changes
Dec 17, 2020
mhdawson
approved these changes
Dec 18, 2020
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI looks good landing. |
Sorry, something went wrong.
mhdawson
pushed a commit
that referenced
this pull request
Dec 18, 2020
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179 PR-URL: #36491 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179 PR-URL: #36491 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
test new Worker() with invalid NODE_OPTIONS Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179 PR-URL: #36491 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test new Worker() with invalid NODE_OPTIONS
Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179
Checklist