lib: add primordials.SafeStringIterator - #36526
Closed
aduh95 wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I found some code, seems they should be submitted together with this PR. node/lib/internal/util/inspect.js Line 2008 in 6837a6d |
Sorry, something went wrong.
aduh95
force-pushed
the
safe-string-iterable
branch
from
e69e07a to
d1ae5c5
Compare
December 15, 2020 14:21
Copy link
Copy Markdown
Contributor
Author
|
@Lxxyx Good catch! I added your suggestions. |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ghost
approved these changes
Dec 22, 2020
ghost
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Benchmark CI (util/inspect): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/797/ (queued) |
Sorry, something went wrong.
Trott
approved these changes
Dec 25, 2020
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
PR-URL: #36526 Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36526 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows node internal function to iterate over strings without relying on String.prototype[Symbol.iterator] and %StringIteratorPrototype%.next, which may be mutated from user-land.
Checklist