FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: refactor to remove optional chaining in events.js by RaisinTen · Pull Request #36539 · nodejs/node · GitHub

/ node Public

lib: refactor to remove optional chaining in events.js - #36539

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/refactor-to-remove-optional-chaining-in-events.js
ConversationCommits (1)ChecksFiles changed
Closed

lib: refactor to remove optional chaining in events.js#36539
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/refactor-to-remove-optional-chaining-in-events.js

Conversation

RaisinTen commented Dec 16, 2020

Copy link
Copy Markdown
Member

Refs: #36528

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Dec 16, 2020
aduh95 reviewed Dec 16, 2020
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why would we want to remove optional chaining?

RaisinTen commented Dec 16, 2020

Copy link
Copy Markdown
Member Author

The reviewers in the referenced PR mentioned that it might have a performance impact and it hinders readability.

jasnell commented Dec 16, 2020

Copy link
Copy Markdown
Member

Since I left the original comment on the performance there have been a few benchmark runs that show the performance with the chaining is good! I'd go ahead and just leave this as is.

Lxxyx commented Dec 16, 2020

Copy link
Copy Markdown
Member

You can look at this pull request: #36524, optional chaining performance looks good.

RaisinTen commented Dec 16, 2020

Copy link
Copy Markdown
Member Author

Thanks for letting me know. I'll try to add optional chaining to other modules then.

RaisinTen closed this Dec 16, 2020
RaisinTen deleted the lib/refactor-to-remove-optional-chaining-in-events.js branch December 16, 2020 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments

Assignees

No one assigned

Labels

events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL