FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix release script by aduh95 · Pull Request #36540 · nodejs/node · GitHub

/ node Public

tools: fix release script - #36540

Closed
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:fix-release-script
ConversationCommits (2)ChecksFiles changed
Closed

tools: fix release script#36540
aduh95 wants to merge 2 commits into
nodejs:masterfrom
aduh95:fix-release-script

Conversation

aduh95 commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

#36123 introduced illformed ssh, scp, and gpg commands. This is my attempt at fixing it.

Refs: #36123 (comment)

/cc @BethGriggs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 16, 2020

BethGriggs commented Dec 16, 2020

Copy link
Copy Markdown
Member

Thanks for the quick PR, I've just tested this locally, and the script runs through as far as expected:

1) A1AB005C
2) D6DCC25D
Select a key: 1

Using GPG key: A1AB005C
  Fingerprint: 4ED778F539E3634C779C87C6D7062848A1AB005C

# Checking for releases ...
No releases to promote!

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 16, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 16, 2020

This comment has been minimized.

Sign in to view
aduh95 commented Dec 16, 2020
View reviewed changes
Comment thread tools/release.sh Outdated

nodejs-github-bot commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34971/

MylesBorins approved these changes Dec 17, 2020
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

MylesBorins commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

fast-track?

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 17, 2020
MylesBorins mentioned this pull request Dec 17, 2020
Closed
2 tasks
richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2020

github-actions Bot commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Landed in 32d58d7...f28715d

github-actions Bot closed this Dec 17, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 17, 2020
tools: fix release script
f28715d 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
aduh95 deleted the fix-release-script branch December 17, 2020 16:43

BethGriggs commented Dec 17, 2020

Copy link
Copy Markdown
Member

I used this version of the script to promote v14.15.3. It successfully promoted the release but I then hit a key related error while uploading the shasums:

Upload files? [y/n] y
Warning: Identity file <key1> not accessible: No such file or directory.
no such identity: <key2>: No such file or directory
dist@direct.nodejs.org's password:

(I reverted to the old version and ran ./tools/release.sh -i <key> -s v14.15.3 to sign.)

aduh95 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

@BethGriggs Do you try to use the -s flag with the current version by any chance?

BethGriggs commented Dec 17, 2020

Copy link
Copy Markdown
Member

@BethGriggs Do you try to use the -s flag with the current version by any chance?

Nope, I only tried to run the full script with ./tools/release.sh -i <key> on the current version.

aduh95 mentioned this pull request Dec 18, 2020
Closed
2 tasks
targos pushed a commit that referenced this pull request Dec 21, 2020
tools: fix release script sign function
6c25870 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
tools: fix release script
27260c7 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Dec 21, 2020
tools: fix release script sign function
e3c5adc 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
tools: fix release script
471da7d 
PR-URL: #36540
Refs: #36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
tools: fix release script sign function
3cac041 
PR-URL: #36556
Refs: #36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams mentioned this pull request May 3, 2021
Merged
snyk-bot mentioned this pull request Sep 13, 2022
Open
ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
wedataintelligence mentioned this pull request Sep 13, 2022
Open
snyk-bot mentioned this pull request Sep 13, 2022
Open
molllyn1 mentioned this pull request Sep 14, 2022
Open
137717unity mentioned this pull request Sep 14, 2022
Open
snyk-bot mentioned this pull request Sep 25, 2022
Open
wedataintelligence mentioned this pull request Sep 26, 2022
Open
137717unity mentioned this pull request Sep 26, 2022
Open
snyk-bot mentioned this pull request Sep 27, 2022
Open
wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
snyk-bot mentioned this pull request Oct 6, 2022
Open
137717unity mentioned this pull request Oct 7, 2022
Open
wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
137717unity mentioned this pull request Oct 9, 2022
Open
snyk-bot mentioned this pull request Oct 9, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL