FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: expand openssl instructions by mhdawson · Pull Request #36554 · nodejs/node · GitHub

/ node Public

doc: expand openssl instructions - #36554

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:openssl-instructions
ConversationCommits (2)ChecksFiles changed
Closed

doc: expand openssl instructions#36554
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:openssl-instructions

Conversation

mhdawson commented Dec 17, 2020

Copy link
Copy Markdown
Member

Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

Related Issues

Fixes: https://github.com/nodejs/node/issues/<issue_number>

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

doc: expand openssl instructions
1a42132 
Refs: nodejs#36541

Expand the instructions to cover what is needed when
updates are required across all active release lines
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2020
mhdawson mentioned this pull request Dec 17, 2020
Merged
2 tasks
richardlau reviewed Dec 17, 2020
View reviewed changes
Comment thread doc/guides/maintaining-openssl.md Outdated
This document describes how to update `deps/openssl/`.

If you need to provide updates across all active release lines you will
currently need to generate two PRs as follows:

richardlau Dec 17, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This time round we did three PRs -- one for current (including the QUIC patches), one for 14.x (without the the QUIC patches) and one for 10.x.

mhdawson Dec 18, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

k will update for that.

mhdawson Dec 18, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@richardlau updated

mhdawson commented Dec 21, 2020

Copy link
Copy Markdown
Member Author

@MylesBorins could you review/approve so I can land?

MylesBorins approved these changes Dec 21, 2020
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

The only concern I have with documenting this is that 10.x is going EOL in april and we won't want to keep the stale docs... so we just need to remember to remove this

mhdawson commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

@MylesBorins understood on updating the docs. I can try to remember to do that, but I think the value of having the info is worth it.

mhdawson commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

Do only change and linters have passed, landing.

mhdawson added a commit that referenced this pull request Dec 22, 2020
doc: expand openssl instructions
e22b751 
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

mhdawson commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

Landed in e22b751

mhdawson closed this Dec 22, 2020
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
doc: expand openssl instructions
dcc93d3 
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 16, 2021
doc: expand openssl instructions
4cf665b 
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
doc: expand openssl instructions
7efa020 
Refs: #36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: #36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL