tools: update gyp-next to v0.7.0 - #36580
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Would love to have some reviews :) |
Sorry, something went wrong.
richardlau
reviewed
Dec 21, 2020
richardlau
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is the mode change (100755 → 100644) for tools/gyp/setup.py intentional?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I wonder if it was unintentionally set to 755 before? I did the update by removing the directory and cloning a fresh one from https://github.com/nodejs/gyp-next |
Sorry, something went wrong.
richardlau
approved these changes
Dec 21, 2020
Trott
approved these changes
Dec 21, 2020
ryzokuken
approved these changes
Dec 24, 2020
Copy link
Copy Markdown
Contributor
|
@targos I suppose those could be landed... |
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Dec 26, 2020
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: #36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: #36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 19, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 19, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 20, 2021
targos
added a commit
that referenced
this pull request
May 25, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: #36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
targos
added a commit
that referenced
this pull request
Jun 5, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: #36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 8, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 9, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 10, 2021
targos
added a commit
that referenced
this pull request
Jun 11, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: #36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
richardlau
pushed a commit
to richardlau/node-1
that referenced
this pull request
Aug 18, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0 PR-URL: nodejs#36580 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0
Checklist