src: use correct microtask queue for checkpoints - #36581
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
I missed in c6c8337 that we should not just use that queue for enqueuing microtasks, but also for running them. Refs: nodejs#36482
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Dec 20, 2020
devsnek
approved these changes
Dec 20, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
added a commit
to addaleax/node
that referenced
this pull request
May 23, 2021
I missed in c6c8337 that we should not just use that queue for enqueuing microtasks, but also for running them. Refs: nodejs#36482 PR-URL: nodejs#36581 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed in c6c8337 that we should not just use that queue for
enqueuing microtasks, but also for running them.
Refs: #36482
Checklist