| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Run Benchmark on my computer, seems the performance issues still exists. confidence improvement accuracy (*) (**) (***) misc/freelist.js n=100000 *** -92.46 % ±1.94% ±2.61% ±3.46% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case there are 1 comparisons, you can thus expect the following amount of false-positive results: 0.05 false positives, when considering a 5% risk acceptance (*, **, ***), 0.01 false positives, when considering a 1% risk acceptance (**, ***), 0.00 false positives, when considering a 0.1% risk acceptance (***) |
Sorry, something went wrong.
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/784/ |
Sorry, something went wrong.
|
Looks like the benchmark CI crashed: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/783/console |
Sorry, something went wrong.
There was a problem hiding this comment.
Benchmark confirmed very poor performance results…
confidence improvement accuracy (*) (**) (***) misc/freelist.js n=100000 *** -91.36 % ±3.89% ±5.24% ±6.96%
Sorry, something went wrong.
|
If I had to guess, I’d say V8 is doing some inlining shenanigans when it detects a push or pop method on an ordinary array with %Array.prototype% in its [[Prototype]] internal slot. By inlining the methods in #37649, I hope to make FreeList faster and resilient to mutation of %Array.prototype%.pop and %Array.prototype%.push |
Sorry, something went wrong.
|
This pull request has been marked as stale due to 90 days of inactivity. |
Sorry, something went wrong.
lib: add `SafeArray` to `primordials` and use it for `FreeList` Refs: nodejs#36304 (comment) Refs: nodejs#36565 Signed-off-by: ExE Boss <ExE-Boss@code.ExE-Boss.tech>
Codecov Report❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #36600 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.02%
==========================================
Files 744 744
Lines 242542 242582 +40
Branches 45690 45700 +10
==========================================
+ Hits 218672 218682 +10
- Misses 15362 15394 +32
+ Partials 8508 8506 -2
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Refs: #36304 (comment)
Refs: #36565
Checklist