FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve coverage for util.inspect() with classes by Trott · Pull Request #36625 · nodejs/node · GitHub

/ node Public

test: improve coverage for util.inspect() with classes - #36625

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:util-inspect-class
Dec 27, 2020
Merged

test: improve coverage for util.inspect() with classes#36625
Trott merged 1 commit into
nodejs:masterfrom
Trott:util-inspect-class

Conversation

Trott commented Dec 25, 2020

Copy link
Copy Markdown
Member

Refs: #36622 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Trott requested a review from BridgeAR December 25, 2020 00:16
nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 25, 2020
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Refs: nodejs#36622 (review)

PR-URL: nodejs#36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott force-pushed the util-inspect-class branch from 3279abb to 75afb6c Compare December 27, 2020 04:31

Trott commented Dec 27, 2020

Copy link
Copy Markdown
Member Author

Landed in 75afb6c

Trott merged commit 75afb6c into nodejs:master Dec 27, 2020
Trott deleted the util-inspect-class branch December 27, 2020 04:31
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Refs: #36622 (review)

PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Refs: #36622 (review)

PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL