FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix unknown warning option by RaisinTen · Pull Request #36629 · nodejs/node · GitHub

/ node Public

build: fix unknown warning option - #36629

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:build/fix-unknown-warning-option-Wno-int-in-bool-context
Closed

build: fix unknown warning option#36629
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:build/fix-unknown-warning-option-Wno-int-in-bool-context

Conversation

RaisinTen commented Dec 25, 2020
edited
Loading

Copy link
Copy Markdown
Member

warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.

The -Wint-in-bool-context diagnostic is not enabled by default,
so no additional option is needed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.

The `-Wint-in-bool-context` diagnostic is not enabled by default,
so no additional option is needed.
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 25, 2020

Copy link
Copy Markdown
Member Author

cc @nodejs/build-files

targos added gyp Issues and PRs related to the GYP tool and .gyp build files request-ci Add this label to start a Jenkins CI on a PR. labels Dec 27, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020

Copy link
Copy Markdown
Collaborator

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2020

Copy link
Copy Markdown
Contributor

Landed in c27efd4...d146b25

github-actions Bot closed this Dec 28, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 28, 2020
warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.

The `-Wint-in-bool-context` diagnostic is not enabled by default,
so no additional option is needed.

PR-URL: #36629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
RaisinTen deleted the build/fix-unknown-warning-option-Wno-int-in-bool-context branch December 28, 2020 13:46
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.

The `-Wint-in-bool-context` diagnostic is not enabled by default,
so no additional option is needed.

PR-URL: #36629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams mentioned this pull request Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gyp Issues and PRs related to the GYP tool and .gyp build files tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL