FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: revert incomingmessage autodestroy by dnlup · Pull Request #36647 · nodejs/node · GitHub

/ node Public

http: revert incomingmessage autodestroy - #36647

Closed
dnlup wants to merge 1 commit into
nodejs:v15.x-stagingfrom
dnlup:fix/revert_incoming_autodestroy
ConversationCommits (1)ChecksFiles changed
Closed

http: revert incomingmessage autodestroy#36647
dnlup wants to merge 1 commit into
nodejs:v15.x-stagingfrom
dnlup:fix/revert_incoming_autodestroy

Conversation

dnlup commented Dec 27, 2020

Copy link
Copy Markdown
Contributor

This reverts commits:

Because of the breaking change in the order of emitting the close event in IncomingMessage described in #33035 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Revert "http: use autoDestroy: true in incoming message"
57f11ca 
This reverts commits:

* 55e83cb
* 6120028
* 70eaf55
* 5ae9690
* f20a88f
* a6bf74e
* 8154e47

Because of the breaking change in the order of emitting the `close`
event in `IncomingMessage` described in:
  nodejs#33035 (comment)
nodejs-github-bot added http Issues or PRs related to the http subsystem. v15.x labels Dec 27, 2020
dnlup mentioned this pull request Dec 27, 2020
Closed
2 tasks
ronag requested a review from mcollina December 27, 2020 20:06

ronag commented Dec 27, 2020

Copy link
Copy Markdown
Member

@nodejs/http

mcollina approved these changes Dec 27, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

devinivy mentioned this pull request Dec 28, 2020
Closed
mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2020

nodejs-github-bot commented Dec 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35111/

MylesBorins pushed a commit that referenced this pull request Jan 5, 2021
Revert "http: use autoDestroy: true in incoming message"
c784f15 
This reverts commits:

* 55e83cb
* 6120028
* 70eaf55
* 5ae9690
* f20a88f
* a6bf74e
* 8154e47

Because of the breaking change in the order of emitting the `close`
event in `IncomingMessage` described in:
  #33035 (comment)

PR-URL: #36647
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Landed in c784f15

MylesBorins closed this Jan 5, 2021
dnlup deleted the fix/revert_incoming_autodestroy branch January 5, 2021 16:23
dnlup mentioned this pull request Jan 12, 2021
Closed
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos mentioned this pull request Jun 5, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes
ronag ronag approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL