FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: finished waits for 'close' on OutgoingMessage by ronag · Pull Request #36648 · nodejs/node · GitHub

/ node Public

stream: finished waits for 'close' on OutgoingMessage - #36648

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:finished-outgoing
ConversationCommits (2)ChecksFiles changed
Closed

stream: finished waits for 'close' on OutgoingMessage#36648
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:finished-outgoing

Conversation

ronag commented Dec 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Don't invoke finished callback until OutgoingMessage has
emitted 'close'.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

ronag requested a review from mcollina December 27, 2020 20:31

ronag commented Dec 27, 2020

Copy link
Copy Markdown
Member Author

@nodejs/http

ronag added http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem. labels Dec 27, 2020
mcollina reviewed Dec 27, 2020
View reviewed changes
Comment thread lib/internal/streams/end-of-stream.js Outdated
ronag commented Dec 27, 2020
View reviewed changes
Comment thread lib/internal/streams/end-of-stream.js Outdated
ronag requested a review from mcollina December 27, 2020 22:23
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 30, 2020
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021

ronag commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

@nodejs/http @nodejs/streams this needs review

stream: finished waits for 'close' on OutgoingMessage
b9d1dda 
Don't invoke finished callback until OutgoingMessagehas
emitted 'close'.
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35310/

mcollina approved these changes Jan 5, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag force-pushed the finished-outgoing branch from ac36161 to fef3c07 Compare January 5, 2021 21:30
ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jan 5, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35314/

mmarchini mentioned this pull request Jan 6, 2021
Closed

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35324/

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35330/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 7, 2021

nodejs-github-bot commented Jan 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35344/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35391/

mcollina approved these changes Jan 9, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35408/

jasnell commented Jan 11, 2021

Copy link
Copy Markdown
Member

Landed in 52546c0

jasnell closed this Jan 11, 2021
jasnell pushed a commit that referenced this pull request Jan 11, 2021
stream: finished waits for 'close' on OutgoingMessage
52546c0 
Don't invoke finished callback until OutgoingMessagehas
emitted 'close'.

PR-URL: #36648
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
stream: finished waits for 'close' on OutgoingMessage
abae61e 
Don't invoke finished callback until OutgoingMessagehas
emitted 'close'.

PR-URL: #36648
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged

targos commented May 25, 2021

Copy link
Copy Markdown
Member

The test fails if I cherry-pick this to v14.x-staging. Assuming it shouldn't land on that branch.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
mafintosh Awaiting requested review from mafintosh
addaleax Awaiting requested review from addaleax
lpinca Awaiting requested review from lpinca
lundibundi Awaiting requested review from lundibundi

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL