stream: only use legacy close listeners if not willEmitClose - #36649
Closed
ronag wants to merge 1 commit into
Closed
stream: only use legacy close listeners if not willEmitClose#36649ronag wants to merge 1 commit into
ronag wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Some streams that willEmitClose unecessarily fallback to legacy events.
Copy link
Copy Markdown
Member
Author
|
@nodejs/streams |
Sorry, something went wrong.
mcollina
approved these changes
Dec 27, 2020
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
Dec 27, 2020
Trott
approved these changes
Dec 28, 2020
lpinca
approved these changes
Dec 28, 2020
Comment thread
test/parallel/test-stream-finished.js
Comment on lines
+506
to
+509
| w.on('finish', () => { | ||
| assert.strictEqual(closed, false); | ||
| w.emit('aborted'); | ||
| }); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit:
Suggested change
| w.on('finish', () => { | |
| assert.strictEqual(closed, false); | |
| w.emit('aborted'); | |
| }); | |
| w.on('finish', common.mustCall(() => { | |
| assert.strictEqual(closed, false); | |
| w.emit('aborted'); | |
| })); |
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 30, 2020
Some streams that willEmitClose unecessarily fallback to legacy events. PR-URL: #36649 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Some streams that willEmitClose unecessarily fallback to legacy events. PR-URL: #36649 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
Some streams that willEmitClose unecessarily fallback to legacy events. PR-URL: #36649 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Some streams that willEmitClose unecessarily fallback to legacy events. PR-URL: #36649 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Some streams that willEmitClose unecessarily fallback to legacy events. PR-URL: #36649 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some streams that willEmitClose unecessarily fallback to legacy
events.
Checklist