FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: fix url.format with ipv6 hostname by Lxxyx · Pull Request #36665 · nodejs/node · GitHub

/ node Public

url: fix url.format with ipv6 hostname - #36665

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-url-ipv6-formats
ConversationCommits (1)ChecksFiles changed
Closed

url: fix url.format with ipv6 hostname#36665
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-url-ipv6-formats

Conversation

Lxxyx commented Dec 28, 2020

Copy link
Copy Markdown
Member

Fixes: #36654

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Dec 28, 2020
lpinca reviewed Dec 28, 2020
View reviewed changes
Comment thread test/parallel/test-url-format.js Outdated
Lxxyx force-pushed the fix-url-ipv6-formats branch from bae596a to f766cb0 Compare December 28, 2020 17:08
Lxxyx requested a review from lpinca December 28, 2020 17:09
ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Dec 28, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2020

nodejs-github-bot commented Dec 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35129/

yashLadha reviewed Dec 30, 2020
View reviewed changes

yashLadha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor changes to use primordials instead of built-in, else changes LGTM.

Comment thread lib/url.js Outdated
Lxxyx force-pushed the fix-url-ipv6-formats branch from f766cb0 to 8cbc844 Compare December 30, 2020 02:56
Lxxyx requested a review from yashLadha December 30, 2020 02:57
Lxxyx force-pushed the fix-url-ipv6-formats branch from 8cbc844 to 244da39 Compare December 30, 2020 03:01
Lxxyx force-pushed the fix-url-ipv6-formats branch from 244da39 to f9fd2f6 Compare December 30, 2020 03:02
yashLadha added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020

github-actions Bot commented Dec 30, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/36665
✔  Done loading data for nodejs/node/pull/36665
----------------------------------- PR info ------------------------------------
Title      url: fix url.format with ipv6 hostname (#36665)
Author     Lxxyx  (@Lxxyx)
Branch     Lxxyx:fix-url-ipv6-formats -> nodejs:master
Labels     author ready, url
Commits    1
 - url: fix url.format with ipv6 hostname
Committers 1
 - ZiJian Liu 
PR-URL: https://github.com/nodejs/node/pull/36665
Fixes: https://github.com/nodejs/node/issues/36654
Reviewed-By: Luigi Pinca 
Reviewed-By: Robert Nagy 
Reviewed-By: Rich Trott 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Yash Ladha 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36665
Fixes: https://github.com/nodejs/node/issues/36654
Reviewed-By: Luigi Pinca 
Reviewed-By: Robert Nagy 
Reviewed-By: Rich Trott 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Yash Ladha 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-12-28T18:44:50Z: https://ci.nodejs.org/job/node-test-pull-request/35129/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - url: fix url.format with ipv6 hostname
- Querying data for job/node-test-pull-request/35129/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Mon, 28 Dec 2020 15:47:53 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36665#pullrequestreview-559235401
   ✔  - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/36665#pullrequestreview-559254174
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36665#pullrequestreview-559361009
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/36665#pullrequestreview-559472531
   ✔  - Yash Ladha (@yashLadha): https://github.com/nodejs/node/pull/36665#pullrequestreview-559779284
   ✖  This PR needs to wait 51 more minutes to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/452857792

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 30, 2020
yashLadha added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 30, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020

github-actions Bot commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Landed in 37acaf6...1b7ac0c

github-actions Bot closed this Dec 30, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2020
url: fix url.format with ipv6 hostname
1b7ac0c 
Fixes: #36654

PR-URL: #36665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Lxxyx deleted the fix-url-ipv6-formats branch December 31, 2020 03:51
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
url: fix url.format with ipv6 hostname
5cb8b16 
Fixes: #36654

PR-URL: #36665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
url: fix url.format with ipv6 hostname
2aff77f 
Fixes: #36654

PR-URL: #36665
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
watilde watilde approved these changes
ronag ronag approved these changes
+1 more reviewer
yashLadha yashLadha approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The deprecated url.format formats ipv6 localhost address wrongly

7 participants

Back | FazBrowse Home | New Git URL