FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document common warning types by jasnell · Pull Request #36713 · nodejs/node · GitHub

/ node Public

doc: document common warning types - #36713

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-warning-types
ConversationCommits (1)ChecksFiles changed
Closed

doc: document common warning types#36713
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-warning-types

Conversation

jasnell commented Dec 31, 2020

Copy link
Copy Markdown
Member

Fixes: #24987
Signed-off-by: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Dec 31, 2020
RaisinTen reviewed Jan 1, 2021
View reviewed changes
Comment thread doc/api/process.md Outdated
Trott reviewed Jan 2, 2021
View reviewed changes
Comment thread doc/api/process.md Outdated
Trott reviewed Jan 2, 2021
View reviewed changes
Comment thread doc/api/process.md Outdated
jasnell commented Jan 2, 2021
View reviewed changes
Comment thread doc/api/process.md Outdated
jasnell commented Jan 2, 2021
View reviewed changes
Comment thread doc/api/process.md Outdated
doc: document common warning types
9d1cc32 
Fixes: nodejs#24987
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the doc-warning-types branch from 36acfc6 to 9d1cc32 Compare January 2, 2021 21:28

jasnell commented Jan 3, 2021

Copy link
Copy Markdown
Member Author

Landed in 5499caa

jasnell closed this Jan 3, 2021
jasnell added a commit that referenced this pull request Jan 3, 2021
doc: document common warning types
5499caa 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
doc: document common warning types
242ce19 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: document common warning types
bcca52c 
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RaisinTen RaisinTen left review comments
Trott Trott approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request for warning documentation

4 participants

Back | FazBrowse Home | New Git URL