FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase read file abort coverage by shootermv · Pull Request #36716 · nodejs/node · GitHub

/ node Public

test: increase read file abort coverage - #36716

Closed
shootermv wants to merge 1 commit into
nodejs:masterfrom
shootermv:increase-abort-readfile-test-coverage
Closed

test: increase read file abort coverage#36716
shootermv wants to merge 1 commit into
nodejs:masterfrom
shootermv:increase-abort-readfile-test-coverage

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 1, 2021
shootermv force-pushed the increase-abort-readfile-test-coverage branch from d347db7 to 5a80156 Compare January 1, 2021 06:43

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I would make the comment shorter, thanks for this :)

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021

Lxxyx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM except one nit, you can include a link in the commit message, to let us know which part of the code test coverage has been improved, like this pull request: #36628

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

Thanks! 🙏

Landed in 8c3cdce 🚀

benjamingr closed this Jan 27, 2021
benjamingr pushed a commit that referenced this pull request Jan 27, 2021
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL