wasi: refactor to avoid unsafe array iteration - #36724
Conversation
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
I might be telling you something you already know, but in the past, we've used for rather than .forEach() for performance purposes. I don't think either of these are hot paths, so it's probably fine. @nodejs/wasi
Sorry, something went wrong.
I'm running benchmarks on my other PRs with changes similar to this one, so far I haven't hit an perf issue. My guess is that both approaches are equivalent, but we can use a for(;;) loop instead if we find out that .forEach() is less efficient. |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
PR-URL: nodejs#36724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #36724 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist