FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: increase coverage for assert/calltracker by Lxxyx · Pull Request #36728 · nodejs/node · GitHub

/ node Public

test: increase coverage for assert/calltracker - #36728

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:test-increase-assert-coverage
Closed

test: increase coverage for assert/calltracker#36728
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:test-increase-assert-coverage

Conversation

Lxxyx commented Jan 2, 2021

Copy link
Copy Markdown
Member
  1. test calls fn parameter is number
    Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30

  2. test calls fn parameter is undefined
    Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 2, 2021

Copy link
Copy Markdown
Collaborator

Lxxyx added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 26, 2021
Lxxyx added a commit that referenced this pull request Jan 27, 2021

Lxxyx commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

Landed in 7016c61

Lxxyx closed this Jan 27, 2021
Lxxyx deleted the test-increase-assert-coverage branch January 27, 2021 02:13
targos pushed a commit that referenced this pull request Feb 2, 2021
targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL