docs: Add references in punycode.md - #36761
Closed
isaacl wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
reviewed
Jan 3, 2021
Comment thread
doc/api/punycode.md
Outdated
Comment thread
doc/api/punycode.md
Outdated
Comment thread
doc/api/punycode.md
Outdated
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding.
Copy link
Copy Markdown
Contributor
Author
|
hmm build can't find the links, but they're properly formatted for md. idk |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
We should use the links I provided in my suggestions above, those will work for the CI. |
Sorry, something went wrong.
aduh95
reviewed
Jan 4, 2021
Comment thread
doc/api/punycode.md
Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Jan 8, 2021
yashLadha
approved these changes
Jan 9, 2021
jasnell
approved these changes
Jan 9, 2021
jasnell
pushed a commit
that referenced
this pull request
Jan 9, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Add references to related `url` functions in punycode.md. These provide guidance to users who may be investigating the punycode module for URL encoding. PR-URL: #36761 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add references to related url functions in punycode.md. These provide
guidance to users who may be investigating the punycode module for URL
encoding.
This is based on confusion I personally experienced reading the deprecation
notice.
Checklist