timers: refactor to use optional chaining - #36767
Closed
Lxxyx wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/874/console No regressions or improvementsconfidence improvement accuracy (*) (**) (***) timers/timers-cancel-pooled.js n=5000000 -0.96 % ±9.53% ±12.68% ±16.51% timers/timers-cancel-unpooled.js direction='end' n=1000000 4.08 % ±7.54% ±10.04% ±13.07% timers/timers-cancel-unpooled.js direction='start' n=1000000 -2.81 % ±5.86% ±7.80% ±10.16% Be aware that when doing many comparisons the risk of a false-positive result increases. In this case there are 3 comparisons, you can thus expect the following amount of false-positive results: 0.15 false positives, when considering a 5% risk acceptance (*, **, ***), 0.03 false positives, when considering a 1% risk acceptance (**, ***), 0.00 false positives, when considering a 0.1% risk acceptance (***) |
Sorry, something went wrong.
aduh95
approved these changes
Jan 5, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Lxxyx
force-pushed
the
timers-refactor-use-optional-chaining
branch
from
fbf05e0 to
738759a
Compare
January 8, 2021 11:33
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jan 9, 2021
jasnell
pushed a commit
that referenced
this pull request
Jan 9, 2021
PR-URL: #36767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
As part of #37937, I tracked down a regression introduced by this one. With optional chaining:
Without optional chaining:
|
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36767 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist