tty: refactor to avoid unsafe array iteration - #36771
Merged
aduh95 merged 0 commit intoJan 6, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
RaisinTen
reviewed
Jan 4, 2021
Comment thread
lib/tty.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is this supposed to be more efficient?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Not really (it's probably equivalent performance wise), it's to avoid calling user-mutable Array.prototype[Symbol.iterator] and %ArrayIteratorPrototype%.next.
Sorry, something went wrong.
Trott
approved these changes
Jan 5, 2021
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PoojaDurgad
approved these changes
Jan 5, 2021
aduh95
force-pushed
the
tty-array-iteration
branch
from
f808e31 to
b12127a
Compare
January 6, 2021 12:03
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36771 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist