FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify subprocess.stdout/in/err/io properties by jasnell · Pull Request #36784 · nodejs/node · GitHub

/ node Public

doc: clarify subprocess.stdout/in/err/io properties - #36784

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-stdio-null
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify subprocess.stdout/in/err/io properties#36784
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-stdio-null

Conversation

jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

The various subprocess.stdwhatever properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell jasnell@gmail.com

doc: clarify subprocess.stdout/in/err/io properties
8da0b14 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: nodejs#33458
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jan 4, 2021
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

jasnell added a commit that referenced this pull request Jan 7, 2021
doc: clarify subprocess.stdout/in/err/io properties
8ce6583 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Jan 7, 2021

Copy link
Copy Markdown
Member Author

Landed in 8ce6583

jasnell closed this Jan 7, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
doc: clarify subprocess.stdout/in/err/io properties
d4bcb36 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: clarify subprocess.stdout/in/err/io properties
c1ea23c 
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: child_process.SpawnSync output, stdout, stderr can be null

3 participants

Back | FazBrowse Home | New Git URL