FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify Buffer.from when using ArrayBuffer by jasnell · Pull Request #36785 · nodejs/node · GitHub

/ node Public

doc: clarify Buffer.from when using ArrayBuffer - #36785

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-buffer-from
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify Buffer.from when using ArrayBuffer#36785
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-buffer-from

Conversation

jasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

Fixes: #31348
Signed-off-by: James M Snell jasnell@gmail.com

doc: clarify Buffer.from when using ArrayBuffer
4b13801 
Fixes: nodejs#31348
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jan 4, 2021
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

Landed in 4be66ca

jasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
doc: clarify Buffer.from when using ArrayBuffer
4be66ca 
Fixes: #31348
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36785
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
doc: clarify Buffer.from when using ArrayBuffer
c6eb2b4 
Fixes: #31348
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36785
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: clarify Buffer.from when using ArrayBuffer
dc15608 
Fixes: #31348
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36785
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for creating a Buffer which shares a TypedArray's memory is misleading

4 participants

Back | FazBrowse Home | New Git URL