FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: guard large string decoder allocation by targos · Pull Request #36795 · nodejs/node · GitHub

/ node Public

test: guard large string decoder allocation - #36795

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
targos:fix-36792
Jan 5, 2021
ConversationCommits (1)ChecksFiles changed
Merged

test: guard large string decoder allocation#36795
aduh95 merged 1 commit into
nodejs:masterfrom
targos:fix-36792

Conversation

targos commented Jan 5, 2021

Copy link
Copy Markdown
Member

Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2021
targos mentioned this pull request Jan 5, 2021
Closed
targos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 5, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021

targos commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

👍 to fast-track and make ARM CI green.

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35268/

test: guard large string decoder allocation
e5b8c61 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: nodejs#36792

PR-URL: nodejs#36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Landed in e5b8c61

aduh95 merged commit e5b8c61 into nodejs:master Jan 5, 2021
targos deleted the fix-36792 branch January 5, 2021 08:43

mhdawson commented Jan 5, 2021

Copy link
Copy Markdown
Member

@targos thanks!

danielleadams pushed a commit that referenced this pull request Jan 12, 2021
test: guard large string decoder allocation
9b7d2c2 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos added a commit that referenced this pull request May 25, 2021
test: guard large string decoder allocation
7f0d5d3 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this pull request Jun 5, 2021
test: guard large string decoder allocation
c9135b8 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this pull request Jun 11, 2021
test: guard large string decoder allocation
c34de75 
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
StefanStojanovic mentioned this pull request Jul 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gireeshpunathil gireeshpunathil approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-string-decoder failing regularly on arm

6 participants

Back | FazBrowse Home | New Git URL