Fix typo in esm documentation - #36800
Merged
aduh95 merged 1 commit intoJan 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gireeshpunathil
approved these changes
Jan 5, 2021
BethGriggs
approved these changes
Jan 5, 2021
RaisinTen
requested changes
Jan 5, 2021
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: maybe change the commit message to:
doc: fix typo in esm.md
Sorry, something went wrong.
aduh95
approved these changes
Jan 5, 2021
richardlau
approved these changes
Jan 5, 2021
Copy link
Copy Markdown
Contributor
This can be done by whoever lands this, our policy is to lift that kind of burden off first-time contributors 😉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track? |
Sorry, something went wrong.
PoojaDurgad
approved these changes
Jan 5, 2021
PR-URL: #36800 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Copy link
Copy Markdown
Contributor
|
Landed in 3c49ee2 🎉 Thanks for the contribution! |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36800 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36800 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.