FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: fix .end() error propagation by ronag · Pull Request #36817 · nodejs/node · GitHub

/ node Public

stream: fix .end() error propagation - #36817

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:writable-end-error
ConversationCommits (4)ChecksFiles changed
Closed

stream: fix .end() error propagation#36817
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:writable-end-error

Conversation

ronag commented Jan 6, 2021

Copy link
Copy Markdown
Member

No description provided.

ronag added the stream Issues and PRs related to the stream subsystem. label Jan 6, 2021
ronag requested review from lpinca and mcollina January 6, 2021 18:46
ronag mentioned this pull request Jan 6, 2021
Closed
ronag force-pushed the writable-end-error branch from 96a3e8f to db00cc2 Compare January 6, 2021 18:47

ronag commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

@nodejs/stream

lpinca reviewed Jan 6, 2021
View reviewed changes
Comment thread test/parallel/test-stream-writable-end-cb-error.js Outdated
ronag requested a review from lpinca January 6, 2021 19:52
lpinca reviewed Jan 6, 2021
View reviewed changes
Comment thread test/parallel/test-stream-writable-end-cb-error.js Outdated
ronag force-pushed the writable-end-error branch from e25f804 to 48ea4c2 Compare January 6, 2021 20:13
ronag force-pushed the writable-end-error branch from c8eb497 to 5443a22 Compare January 6, 2021 20:18

ronag commented Jan 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@lpinca: Though I agree that the behavior is a little strange and should be discussed I'm not sure it's relevant for this PR other than we noticed it with the tests added here.

lpinca commented Jan 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I agree, I vaguely remember having already discussed it in an old PR (It was probably the PR calling all pending callbacks on error) but I may be wrong.

lpinca approved these changes Jan 6, 2021
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGMT

mcollina approved these changes Jan 6, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jan 6, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35341/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2021

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35393/

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35404/

ronag added a commit that referenced this pull request Jan 11, 2021
stream: fix .end() error propagation
a4fce32 
PR-URL: #36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

ronag commented Jan 11, 2021

Copy link
Copy Markdown
Member Author

Landed in a4fce32

ronag closed this Jan 11, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
stream: fix .end() error propagation
4c819d6 
PR-URL: #36817
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
lpinca mentioned this pull request Jan 23, 2021
Closed
mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 25, 2021

mcollina commented Jan 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

mark this as semver-major post-release as it broke things in v15 :(, see #37027 for more details.

cc @nodejs/tsc

MrJithil mentioned this pull request Jan 26, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL