FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify descriptions of _writev chunks argument by jasnell · Pull Request #36822 · nodejs/node · GitHub

/ node Public

doc: clarify descriptions of _writev chunks argument - #36822

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-writev
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify descriptions of _writev chunks argument#36822
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-writev

Conversation

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
Member

Fixes: #36789
Signed-off-by: James M Snell jasnell@gmail.com

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 6, 2021
jasnell requested a review from mcollina January 6, 2021 22:02
mcollina approved these changes Jan 6, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 6, 2021
addaleax reviewed Jan 8, 2021
View reviewed changes
Comment thread doc/api/stream.md Outdated
Comment thread doc/api/stream.md Outdated
doc: clarify descriptions of _writev chunks argument
c62ae74 
Fixes: nodejs#36789
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the doc-clarify-writev branch from 5dc7a50 to c62ae74 Compare January 8, 2021 17:00

jasnell commented Jan 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 96c3498

jasnell closed this Jan 9, 2021
jasnell added a commit that referenced this pull request Jan 9, 2021
doc: clarify descriptions of _writev chunks argument
96c3498 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
doc: clarify descriptions of _writev chunks argument
1a4d34e 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: clarify descriptions of _writev chunks argument
f605bc0 
Fixes: #36789
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax left review comments
mcollina mcollina approved these changes
watilde watilde approved these changes
+1 more reviewer
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: description for chunks in _writev in stream_writable

6 participants

Back | FazBrowse Home | New Git URL