stdio: lazy read ReadStream - #36823
Closed
ronag wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
All stdio ReadStream's use manual start to avoid consuming data for example when a process execs/spawns. Using stream._construct would cause the Readable to incorrectly greedily start reading. Refs: nodejs#36251
mcollina
approved these changes
Jan 6, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/streams |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Jan 7, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This is not a PR targeting v15.x, so I've removed the label. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
benjamingr
approved these changes
Jan 10, 2021
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36823 ✔ Done loading data for nodejs/node/pull/36823 ----------------------------------- PR info ------------------------------------ Title stdio: lazy read ReadStream (#36823) Author Robert Nagy (@ronag) Branch ronag:stdin-lazy -> nodejs:master Labels author ready, stream Commits 2 - stdio: lazy read ReadStream - fixup: use needReadable Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/36823 Refs: https://github.com/nodejs/node/issues/36251 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36823 Refs: https://github.com/nodejs/node/issues/36251 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-01-06T23:06:21Z: https://ci.nodejs.org/job/node-test-pull-request/35342/ - Querying data for job/node-test-pull-request/35342/ ✔ Build data downloaded - Querying failures of job/node-test-commit/43421/ ✔ Data downloaded ✖ 6 failure(s) on the last Jenkins CI run ℹ This PR was created on Wed, 06 Jan 2021 22:24:11 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/36823#pullrequestreview-563341020 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/36823#pullrequestreview-564867931 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/475761868 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All stdio ReadStream's use manual start to avoid
consuming data for example when a process
execs/spawns.
Using stream._construct would cause the Readable
to incorrectly greedily start reading.
Refs: #36251